fix(eio): make _query optional in EngineRequest#5495
Closed
elementnl wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for your report 👍 I think this was (indirectly) fixed by b059af6, included in So I think we can close this. Please reopen if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5468
EngineRequestdeclared_queryas required, but the property is set lazily byprepare()and doesn't exist on a rawIncomingMessage. This caused a TypeScript error when passing a plainIncomingMessagewhere anEngineRequestis expected; for example, in Nuxt integrations following the official guide.Before: Any code that worked with
EngineRequestdirectly would get a TypeScript mismatch error because_querywas required but not present on the underlyingIncomingMessage.After:
_queryis typed as optional inEngineRequestand in theTransportconstructor, which correctly reflects the lifecycle of the property: it may not be set at construction time, but is always guaranteed to be present by the time any transport logic runs.transports/index.tsis also updated for consistency.No tests added - this is a TypeScript-only change with no runtime behavior difference.